Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Block Patterns - CTA - Grid layout with products and link #68

Closed
juanfra opened this issue Aug 19, 2024 · 6 comments Β· Fixed by #273
Closed

Block Patterns - CTA - Grid layout with products and link #68

juanfra opened this issue Aug 19, 2024 · 6 comments Β· Fixed by #273
Labels
[Component] Block Patterns [Priority] High Used to indicate top priority items that need quick attention [Status] Needs Design Feedback Needs general design feedback.

Comments

@juanfra
Copy link
Member

juanfra commented Aug 19, 2024

Description

πŸ› οΈ The goal of this issue is to track the implementation of the Call to action - Grid layout with products and link pattern.
πŸ§‘β€πŸ’» The implementation must follow the pattern creation guidelines, and should be assigned to its appropriate category.
🎨 Figma design

CTA_ Grid layout with products and link

@karmatosed
Copy link
Member

Assigning to myself but also noting this is blocked by presets #36

@carolinan
Copy link
Contributor

This is no longer be blocked.

@juanfra juanfra added the [Priority] High Used to indicate top priority items that need quick attention label Sep 9, 2024
@graylaurenm
Copy link
Contributor

I will give this a go.

graylaurenm added a commit to graylaurenm/twentytwentyfive that referenced this issue Sep 11, 2024
@graylaurenm
Copy link
Contributor

Questions:

  1. Should the text at the top ("Our online store.") be a heading?
  2. Should the text at the top be centered?
  3. Please check the following locations and let me know if you want me to swap to a preset or hardcoded value:
    • Heading: font-size and letter-spacing hardcoded
    • Grid text: font-size preset (18px instead of 16px)
    • "$30": font-size hardcoded
  4. Should I use a class and CSS to force the square aspect ratio on all grid items? For example, in my pull request you'll notice that if a smaller screen doesn't have an image in its row, those items won't be as tall as mocked.
  5. Thoughts on implementation of grid here? On mid-size devices the last row may not be full.

@juanfra juanfra linked a pull request Sep 12, 2024 that will close this issue
@graylaurenm
Copy link
Contributor

@beafialho can you address the above questions when you have a free moment?

@carolinan carolinan added the [Status] Needs Design Feedback Needs general design feedback. label Sep 13, 2024
@karmatosed karmatosed removed their assignment Sep 16, 2024
@beafialho
Copy link
Contributor

I left a comment here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Component] Block Patterns [Priority] High Used to indicate top priority items that need quick attention [Status] Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants