Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Gallery block: Small gallery images with captions and links are not clickable #238

Closed
carolinan opened this issue Oct 2, 2020 · 6 comments · Fixed by #417
Closed

Gallery block: Small gallery images with captions and links are not clickable #238

carolinan opened this issue Oct 2, 2020 · 6 comments · Fixed by #417
Assignees
Labels
[Component] Default blocks Issues related to adjusting default blocks Low priority [Type] Bug Something isn't working

Comments

@carolinan
Copy link
Contributor

Describe the bug
When a gallery image is very small and has both a link and a caption, the caption covers the clickable area of the image.

To Reproduce
Steps to reproduce the behavior:

  1. Add a gallery block to a post or page
  2. Add a caption to the image
  3. Select one of the link options in the block sidebar
  4. Set the gallery so that the images are fairly small
  5. save and view the error on the front.

Expected behavior
The link needs to be clickable

Screenshots
gallery-link

@carolinan carolinan added [Component] Default blocks Issues related to adjusting default blocks [Type] Bug Something isn't working labels Oct 2, 2020
@melchoyce
Copy link
Contributor

Looks like this is a Gutenberg bug — I'm able to reproduce using different themes, including the Gutenberg starter theme. Seems like something we should tackle in Gutenberg itself.

@carolinan carolinan added the Gutenberg Create a new issue in the Gutenberg Github repository label Oct 3, 2020
@carolinan
Copy link
Contributor Author

There might be open issues for it in the Gutenberg repo, I did not check, but for now I added the label.

@carolinan
Copy link
Contributor Author

@kjellr I found this Gutenberg issue,
WordPress/gutenberg#24896

Do you know if there is one open for the problem above though?

@kjellr
Copy link
Collaborator

kjellr commented Oct 8, 2020

No, I haven't seen a bug report for the problem described above. I think a fresh one is appropriate.

@aristath
Copy link
Member

aristath commented Oct 9, 2020

I've been examining this one for a while and the more I look at it the more it looks like this is not an issue.
If users add a small image with large caption, then it's really a problem with the content, not the theme or the editor or the HTML generated.
The one thing I'd suggest doing here is to change the font-size for these from --global--font-size-sm to --global--font-size-xs so they are 1em instead of 1.125em. That will make them fit a little better...

@carolinan
Copy link
Contributor Author

Let's go with reducing the size.

@carolinan carolinan modified the milestone: Full Site Editing Oct 12, 2020
@carolinan carolinan removed the Gutenberg Create a new issue in the Gutenberg Github repository label Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Component] Default blocks Issues related to adjusting default blocks Low priority [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants