Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Switch theme.json to v2 (remove "custom" prefix) #210

Closed
carolinan opened this issue Nov 5, 2021 · 2 comments
Closed

Switch theme.json to v2 (remove "custom" prefix) #210

carolinan opened this issue Nov 5, 2021 · 2 comments

Comments

@carolinan
Copy link
Collaborator

While version 1 will still work in 5.9, I think the theme should use version 2:
WordPress/gutenberg#36155

Do we also need to wait for SchemaStore/schemastore#1907?

@carolinan
Copy link
Collaborator Author

carolinan commented Nov 26, 2021

@ajlende is this the correct way to add the schema back?
"$schema": "https://schemas.wp.org/trunk/theme.json",
Does it now support version 2 of theme.json?

(I needed to remove it here: https://github.com/WordPress/twentytwentytwo/pull/217/files#diff-160c735a986cf8c05e1f6b2e9ac89dd0410562d2fe5ccbdc93157bd92f3dc2bcL2)

@ajlende
Copy link

ajlende commented Nov 26, 2021

That is correct for Visual Studio Code for the latest version. The latest version, however, had a bug where the version was not updated with the changed properties, so I added a fix here WordPress/gutenberg#36917

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants