Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text spacing and buttons consistent between TOTP and Backup Code screens #515

Open
ironprogrammer opened this issue Feb 9, 2023 · 5 comments
Labels
Backup Codes TOTP Time-based One-time Passwords
Milestone

Comments

@ironprogrammer
Copy link

I have two small visual suggestions:

  • In the TOTP window, an empty line should be inserted between the instructions and field label.
  • In the Backup Code window, change the "Submit" button to read "Authenticate" for consistency with the TOTP screen. This action word makes sense regardless of the authentication method employed.

auth-screen
Figure 1: Animation comparing TOTP and Backup Code entry screens.

@iandunn
Copy link
Member

iandunn commented Feb 9, 2023

( that UI comes from the Two Factor plugin, so I'm gonna move this issue there )


Adding the blank line makes sense to me 👍🏻

I'm not sure if Authenticate is a word most users will be familiar with, but Submit isn't either. I wonder if there's a better one? Maybe just Log in, since that's what will happen if the code is successful? I don't feel strongly about any of that, though.

@iandunn iandunn transferred this issue from WordPress/wporg-two-factor Feb 9, 2023
@iandunn iandunn added TOTP Time-based One-time Passwords Backup Codes labels Feb 9, 2023
@jeffpaul
Copy link
Member

Verify or Verify code perhaps?

@dd32
Copy link
Member

dd32 commented Apr 28, 2023

In the TOTP window, an empty line should be inserted between the instructions and field label.

This was resolved through #521 I believe.

change the "Submit" button to read "Authenticate" for consistency with the TOTP screen.

  • Backup/Recovery Codes: Submit
  • TOTP: Authenticate
  • Email: Log In
  • Dummy: Yup

I think Continue works the best IMHO, even though a minority of the examples below use it.
I would be equally happy with Verify though, as both are descriptive of the action taking place "Verify this code is correct and login" "Continue login with this code", where as "Submit this Code", "Log In with this code" and "Authenticate with this code" don't feel quite the same.

Similar to #486 (comment) I've gone through and looked at various other UI's

WordPress.com GitHub Amazon Google
Screenshot 2023-04-28 at 3 55 18 pm Screenshot 2023-04-28 at 3 56 08 pm Screenshot 2023-04-28 at 3 56 28 pm Screenshot 2023-04-28 at 3 58 43 pm
Microsoft Stripe Instagram Mastodon
Screenshot 2023-04-28 at 3 59 44 pm Screenshot 2023-04-28 at 4 56 31 pm Screenshot 2023-04-28 at 4 57 34 pm Screenshot 2023-04-28 at 4 59 40 pm

@dd32
Copy link
Member

dd32 commented Apr 28, 2023

Another aspect worthwhile considering here is the action for Security keys, which may want/need to include an explicit user-interaction step to trigger it.
While I don't think it would prevent any phrases above, it would be nice for consistency.

An example of an explicit user-interaction step is GitHub:

Screen.Recording.2023-04-28.at.5.08.30.pm.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backup Codes TOTP Time-based One-time Passwords
Projects
None yet
Development

No branches or pull requests

5 participants
@iandunn @dd32 @ironprogrammer @jeffpaul and others