Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enforce" tag use via guidelines #77

Open
Clorith opened this issue Aug 9, 2021 · 2 comments
Open

"Enforce" tag use via guidelines #77

Clorith opened this issue Aug 9, 2021 · 2 comments

Comments

@Clorith
Copy link
Member

Clorith commented Aug 9, 2021

A post was made this year, outlining how tags are preferred over just using trunk for releases (https://make.wordpress.org/plugins/2021/03/16/trunk-vs-tags-which-is-better-tags/).

In light of this, I'd like to propose that we make the use of tags enforceable via the guidelines.

The biggest factor for this is automated rollbacks of a failed automatic update, this also goes for the use of wpackagist for those that use composer, since they honor the plugin directory and their available versions, and remove older versions that are no longer served by the directory.

My thinking is that the guidelines should require the use of tags moving forward, with any new release made (so as not to punish those who have used trunk and haven't made changes since).

I'm not sure if this would be enforceable on a directory level with code or not, since trunk should obviously still be available for those using it as a beta channel, but with the guidelines in place, it would at least be possible to push people to doing it right and some stern words if they don't.

@Ipstenu
Copy link
Contributor

Ipstenu commented Aug 9, 2021

I'm flagging this 'maybe later' because, as I know you know, I hate making guidelines that aren't easily enforcable.

Now we do check for (and push back on) this in reviews, but that only covers new plugins and old ones closed for reasons.

Before we look into making this a guideline, I would rather we put time in to blocking the use of 'trunk' as a valid tag in SVN. If we can do that, then we don't need a guideline because, neener, it's already blocked.

I'm not sure if this would be enforceable on a directory level with code or not, since trunk should obviously still be available for those using it as a beta channel

Well now that's a fun thing. SHOULD Trunk be available for a beta channel? Why not make people always use tags? Release a tag 1.3.1-rc1 and so on. After all, Core can...

@Clorith
Copy link
Member Author

Clorith commented Aug 12, 2021

Yeah, totally on board with the difficulty of not-easily enforceable guidelines, just got burnt by the third trunk-only plugin in a week, so it made sense to put my thoughts and ideas to words, no discussion or change without it after all :)

I actually kind of like the idea of not using trunk for betas, and instead having releases that you don't mark as stable tags. That should also work well with any automated deploy systems folks are using, just don't change stable tag when creating your deploy and you've got a pre-release/beta/whatever 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants