Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing 2FA settings through wp-admin #52

Open
2 tasks
iandunn opened this issue Feb 8, 2023 · 1 comment
Open
2 tasks

Prevent changing 2FA settings through wp-admin #52

iandunn opened this issue Feb 8, 2023 · 1 comment

Comments

@iandunn
Copy link
Member

iandunn commented Feb 8, 2023

We already hide the UI that the two-factor plugin adds to profile.php, but our custom UI also includes password/email, and those are still in wp-admin/buddypress/bbpress/etc.

there's a lot of settings on wp-admin/profile.php that should not be changed there, and in the case of WordCamp, will cause the WordPress.org user data to get out of sync with the database.
#13 (comment)

  • If a setting exists in the custom wporg-two-factor UI, then it'd ideally be removed from wp-admin/buddypress/bbpress/etc profile editors, and replaced w/ a link to the 2FA settings screen
  • wp_user* database values on sites that share user tables (wordcamp, buddypress, others?) should also be replaced w/ a link to the w.org profile editor

We might need to delay this while #114 is still using wp-admin, before the custom UI is built.

@dd32
Copy link
Member

dd32 commented Feb 9, 2023

I've gone back and forth on this, the wp-admin profile page is not accessible by most users, but is still required for Application Passwords (As used by the PHPUnit Test Reporters).

It feels like a complete hack, but filters and blocking change attempts doesn't seem to be worth it, and I don't like the look of the code.. so.. I'm super temped to just deploy some Javascript to remove the fields we don't want changed, along with a big banner.. That's what has resulted in me making #54.

@StevenDufresne StevenDufresne removed this from the Iteration 2 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants