Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite DCF77 module #3

Open
kbabioch opened this issue Jan 18, 2014 · 0 comments
Open

Rewrite DCF77 module #3

kbabioch opened this issue Jan 18, 2014 · 0 comments

Comments

@kbabioch
Copy link
Member

The DCF77 module in its current form has a bunch of problems:

  • There are a lot of reports of bad reception, quite possibly having to do with problems in the routines itself.
  • The module is hard to maintain without messing something up, because of all the conditions. An implementation in form of a FSM would make much more sense.
  • The log output is buggy as the same timings are being output multiple times, although nothing has changed internally.
  • The log output is ugly and not that great to read as the lines get way to long.
  • Receiver type detection is not necessary as this can be accommodated easily by either a software switch and/or simple hardware. All known receivers have an inverted output, anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant