Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub workspaces #137

Open
nicholasspencer opened this issue Dec 17, 2024 · 3 comments · May be fixed by #138
Open

Pub workspaces #137

nicholasspencer opened this issue Dec 17, 2024 · 3 comments · May be fixed by #138

Comments

@nicholasspencer
Copy link

The reliance on .dart_tool/package_config.json does not work with Dart's new pub workspaces as those do not get generated in each individual package in a workspace. In workspaces, only a root configuration is generated.
@Levi-Lesches Levi-Lesches mentioned this issue Dec 23, 2024
Closed
@Levi-Lesches
Copy link

Levi-Lesches commented Dec 23, 2024 •
edited
Loading

Also, that error you're describing occurs when running the validator in a specific sub-package, but the validator should ideally support running on the workspace as a whole, and run recursively on sub-packages as needed. Right now it doesn't throw an error but shows that all imports occur outside lib of the workspace (which is always true).

@Levi-Lesches
Copy link

Levi-Lesches commented Dec 23, 2024 •
edited
Loading

Hm, package:pubspec_parse doesn't include support for the workspace or resolution keys. I think that's a blocker.

Edit: Submitted a PR at dart-lang/tools#1948

@Levi-Lesches Levi-Lesches linked a pull request Dec 23, 2024 that will close this issue
Draft
@Levi-Lesches
Copy link

Levi-Lesches commented Dec 23, 2024 •
edited
Loading

Opened #138 to fix this. Works fine for my projects, so feel free to try my git branch until it is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Pub Workspaces Levi-Lesches/dependency_validator
2 participants
@nicholasspencer @Levi-Lesches