Feature/issue 124 #234
Merged
Feature/issue 124 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean/format code, improve generetad code (type, use statement for InvalidArgumentException, array short notation, fix tutorial), add link to MANIFEST, update unit tests
…licable in order to avoid the notice "does not comply with psr-4 autoloading standard. Skipping."
remove @todo
…ibxml libxml is required to use XMLReader::XML method for xml string validation
remove @todo
…ibxml libxml is required to use XMLReader::XML method for xml string validation
Add use statement for SoapFault class Use local variable instead of getResult call in order to return the result
Add new line before `return $this;` statement in setter, Use InvalidArgumentException short name in method doc comment, Improve List (#158), XML (#128) and Array property declaration and its associated setter, Review code to remove useless method, Require `ext-libxml` from now in order to provide XML validation rule, to be improved in the future, Remove DayOfWeekType from XSD types, it should be handled correctly, it is a EWS type that is well declared...
replace ext-libxml by ext-dom
mark as final classes that should be final :) one step further to reach next release :)
Initialize issue templates
…ator into feature/issue-124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations required to fix #124 and #179