Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix base url for preview command #27

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

frank-zsy
Copy link
Contributor

Description

This PR will fix the base URL config in the /preview command.

The config will read the env first to set the base URL, so in the action, we set the env to pull_${pull_number}, so the deployed website will use this as the base URL which not break all the relative links in the website.

Resolved issues

Closes #26

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from ad2c290 to 71e0028 Compare July 8, 2024 13:39
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from 71e0028 to 7f42ae1 Compare July 8, 2024 13:43
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from 7f42ae1 to 3ca446e Compare July 8, 2024 13:51
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from 3ca446e to ca838e0 Compare July 8, 2024 13:56
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from ca838e0 to 3431861 Compare July 8, 2024 14:05
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from 3431861 to cd03a80 Compare July 8, 2024 14:10
@frank-zsy
Copy link
Contributor Author

/preview

Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from cd03a80 to e9be24f Compare July 8, 2024 14:25
@frank-zsy
Copy link
Contributor Author

/preview

@frank-zsy frank-zsy force-pushed the fix/fix-preview-base-url branch from e9be24f to c5e7be8 Compare July 8, 2024 14:27
@frank-zsy frank-zsy merged commit c2ecbc7 into X-lab2017:master Jul 8, 2024
1 check passed
@frank-zsy frank-zsy deleted the fix/fix-preview-base-url branch July 8, 2024 14:27
Copy link

github-actions bot commented Jul 8, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_27/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Base URL should be modified in the /preview command
1 participant