Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved the issue where the GitHub icon pointed to only the "website" repository. #47

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

Peng99999
Copy link
Collaborator

Description

Improved the issue (#46) where the GitHub icon pointed to only the "website" repository. It has now been changed to a dropdown, allowing users to choose between accessing "opendigger" or "opendigger-website."

image

Resolved issues

Closes #46

Signed-off-by: Peng99999 <[email protected]>
@frank-zsy
Copy link
Contributor

It makes sense to use dropdown item here. I commit to:

  • It should be GitHub rather than Github
  • For links, we should remove GitHub and redundant words to keep it neat
  • If we do not need the icon, we could just remove the css rather than comment them

But still, I think the icon is much better looking than GitHub plain text, but I can not figure out how to add a dropdown list to an icon in the navbar.

@Neilblaze WDYT? Is there any way to add link list to an icon and make it a dropdown item?

@Neilblaze
Copy link
Member

@frank-zsy, @Peng99999 I don't have edit/write privileges (since I'm a non-member of x-lab2017), so I'm linking my reviews/suggestions herewith. Just replace the current content for docusaurus.config.ts and custom.css with my content, which can be found → here .

Preview:

Landscape Preview Mobile Preview
prev1 prev2

@Neilblaze
Copy link
Member

Btw, now that I've already mentioned it, I'm really curious to know how an existing contributor can be a part of X-lab2017 GitHub org? 🤔

@Peng99999
Copy link
Collaborator Author

@frank-zsy, @Peng99999 I don't have edit/write privileges (since I'm a non-member of x-lab2017), so I'm linking my reviews/suggestions herewith. Just replace the current content for docusaurus.config.ts and custom.css with my content, which can be found → here .

Preview:

Landscape Preview Mobile Preview
prev1 prev2

Thank you, @Neilblaze , for the great solution.😄 @frank-zsy, Can we invite @Neilblaze to join in X-lab2017 GitHub org?

@frank-zsy
Copy link
Contributor

@Neilblaze Great, if you are interested in our work, I can invite you as a member of X-lab and committer of this repo.

@Neilblaze
Copy link
Member

@frank-zsy Sure, would love to be a part of the family! 😃

@frank-zsy
Copy link
Contributor

@Neilblaze Invitation sent. Welcome to X-lab and OpenDigger~~

@Peng99999 Peng99999 merged commit 53aa5fe into X-lab2017:master Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does the repository that the website is directed to need improvement?
3 participants