Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] 代码质量提升 #86

Open
1 of 5 tasks
stevending1st opened this issue Apr 26, 2023 · 8 comments · Fixed by #97
Open
1 of 5 tasks

[suggestion] 代码质量提升 #86

stevending1st opened this issue Apr 26, 2023 · 8 comments · Fixed by #97

Comments

@stevending1st
Copy link
Contributor

stevending1st commented Apr 26, 2023 •
edited
Loading

前情详见： #85

这里给出一个 Roadmap 以提高代码质量：

  • 将包管理工具迁移到 pnpm feat: change to pnpm #87
  • 将工具链工具迁移到 vitejs
  • 引入 eslint
  • 利用 husky 与 lint-staged 将 eslint 等代码规范工具集成进工作流
  • 切换 TypeScript
@andyhuang18
Copy link
Collaborator

很好的建议，感谢你！

@stevending1st
Copy link
Contributor Author

很好的建议，感谢你！

不客气~

@tyn1998
Copy link
Member

tyn1998 commented Jun 6, 2023

强烈赞同，刚刚就因为js没有报错造成了一个粗心的merge 😆 可以优先考虑现在提交PR时触发一个CI看看能不能build成功。

@wj23027
Copy link
Contributor

wj23027 commented Jun 6, 2023

强烈赞同，刚刚就因为js没有报错造成了一个粗心的merge 😆 可以优先考虑现在提交PR时触发一个CI看看能不能build成功。

我会尽快实现这个ci~

@wj23027 wj23027 mentioned this issue Jun 6, 2023
Merged
9 tasks
@stevending1st
Copy link
Contributor Author

stevending1st commented Jun 7, 2023 •
edited
Loading

@tyn1998 @wj23027 请重开这个 issue

@tyn1998
Copy link
Member

tyn1998 commented Jun 7, 2023

😆 @wj23027 我特意把 #97 的Description中的“resolve”关键词去掉的，又给加回来了哈哈

因为这个issue涉及好几个task，所以需要等全部都完成才能关闭~

@tyn1998 tyn1998 reopened this Jun 7, 2023
@stevending1st stevending1st mentioned this issue Jun 7, 2023
Merged
9 tasks
@TieWay59
Copy link
Member

TieWay59 commented Sep 3, 2023

光是 切换 TypeScript 这一步我觉得就值得一个大 issue 单独 track 👍

@stevending1st
Copy link
Contributor Author

光是 切换 TypeScript 这一步我觉得就值得一个大 issue 单独 track 👍

可以先混合，剥离 js, 所以可以慢慢来

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add CI to trigger build on PR submission wj23027/open-leaderboard
5 participants
@stevending1st @tyn1998 @TieWay59 @andyhuang18 @wj23027