Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 Issues:Cave Sky, Cave Shadow, DH Highlight Reflection #386

Open
xiaozhuo256 opened this issue Jan 15, 2025 · 7 comments
Open

3 Issues:Cave Sky, Cave Shadow, DH Highlight Reflection #386

xiaozhuo256 opened this issue Jan 15, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@xiaozhuo256
Copy link

Describe the bug

1.Cave Sky
Watch the video and you'll notice that the sky turns dark when you're inside a cave, by adjusting the options in the settings regarding cave mode doesn't work.

2025-01-15.22-52-01.mp4

2.Cave Shadow
Watch the video and you will see that inside this cave, all the shadows are displayed in a strange way that looks like a mosaic.

2025-01-15.22-53-27.mp4

3.DH Highlight Reflection
Watch the video, when DH is loaded with “Highlight Reflections” turned on, the reflections in the part of the DH rendering get weird, there should be a better solution to deal with this part instead of rigidly dividing the two!

2025-01-15.22-57-32.mp4.mp4
@xiaozhuo256 xiaozhuo256 added the bug Something isn't working label Jan 15, 2025
@xiaozhuo256
Copy link
Author

I use the "spbr" texture package. Other DH-supported lighting and shadowing tools (such as photon) handle the highlight reflections at the joints better.

@X0nk
Copy link
Owner

X0nk commented Jan 15, 2025

for the cave fog issue:
you are not toggling the setting to turn it on or off. that is in shader settings -> fog settings -> cave fog
cave fog intentionally blacks out the sky so you dont see it when in caves.

for the blocky shadows issue:
that is also intentional. its part of how i prevent sunlight from leaking on walls in caves, its very hacky but its better than no shadows at all

for the sun reflection on distant horizons:
that is not supposed to happen at all. i will look into fixing that

@xiaozhuo256
Copy link
Author

xiaozhuo256 commented Jan 15, 2025

for the blocky shadows issue:
that is also intentional. its part of how i prevent sunlight from leaking on walls in caves, its very hacky but its better than no shadows at all

Is it possible to provide an option for players to turn off "blocky shadows"?

@X0nk
Copy link
Owner

X0nk commented Jan 16, 2025

should be an old lightleak fix option in shader settings -> direct light
not sure if it still functions

@xiaozhuo256
Copy link
Author

xiaozhuo256 commented Jan 16, 2025

Regarding the sun reflection on distant horizons, here's a new video to show the severity of the problem, I turned on highlight reflections, screen space reflections, and fog reflections, and this is how DH behaves.

2025-01-16.12-26-06.mp4

image

You can see that the terrain becomes like a mirror, and the light source in the near distance seems to be extended indefinitely by the mountain, a very strange performance.

@xiaozhuo256
Copy link
Author

should be an old lightleak fix option in shader settings -> direct light not sure if it still functions

image

This option doesn't work, hopefully an additional option will be provided to fix this issue.

@X0nk
Copy link
Owner

X0nk commented Jan 16, 2025

like i said, its not an issue. its intentional

the other major issue with reflections on DH, i honestly have no idea how thats happening. the LOD's have no reflection controls so it shouldnt be able to even get shiny in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants