Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCM Audio Rate might not match hardware #209

Open
Yazwh0 opened this issue Dec 29, 2023 · 1 comment
Open

PCM Audio Rate might not match hardware #209

Yazwh0 opened this issue Dec 29, 2023 · 1 comment
Labels
stalled Resolution of the issue depends on factors outside of our control

Comments

@Yazwh0
Copy link

Yazwh0 commented Dec 29, 2023

The emulator looks like it does something when a signed value is written to the PCM Audio Rate.

I can't find anything in the Vera code that matches this logic. The commit comment mentions its to do with PCM looping, but as that hasn't been merged, should this be here?

pcm_write_rate(uint8_t val)
{
	rate = (val > 128) ? (256 - val) : val;
}
@mooinglemur
Copy link
Contributor

We will need to resolve this based on the outcome of X16Community/vera-module#24

@mooinglemur mooinglemur added the stalled Resolution of the issue depends on factors outside of our control label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stalled Resolution of the issue depends on factors outside of our control
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mooinglemur @Yazwh0