Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a one-dimensional (spectral fit) statistical model suitable for low/high energy #92

Open
kdund opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request inference Statistics code physics This PR mainly deals with physics

Comments

@kdund
Copy link
Collaborator

kdund commented Sep 28, 2023

Several searches use 1D spectral fits, binned or unbinned.
They use sometimes functional forms for background/signals, and sometimes templates.
It would be great to make a general class for these searches!

Such a class should:

  • Allow the definition of binned or unbinned likelihoods
  • Allow the definition of sources as:
    • Functional forms (in particular ease of putting in flat+gaussians)
    • Templates (using inference interface)
    • with rate uncertainties and ancillary constraints as in the blueice class.
    • With or without applying an efficiency curve + convolution either in true energy (standard convolution) or in reconstructed energy (as in the lowER search)
  • Allow combined fits of several 1D fits
  • Allow useful goodness of fit tests?

This class could be defined inside alea, or perhaps in another package depending on alea?
The most important point will be that it is on the same form as the other statistical model classes, allowing you to move between just fitting and full Neyman constructions relatively easily.

@kdund
Copy link
Collaborator Author

kdund commented Sep 28, 2023

@cecilia-ferrari @hammannr since we chatted.
Also
@yuema137 and @jingqiangye -- do you think this makes sense also for lowER as a goal for the medium term?

@kdund kdund added enhancement New feature or request inference Statistics code physics This PR mainly deals with physics labels Sep 28, 2023
@hammannr
Copy link
Collaborator

Also @matteoguida might be interested

@matteoguida
Copy link

@kdund, @hammannr, I'll try to contribute to developing this class, though it might not be in the immediate future.

@jingqiangye
Copy link

Yeah that'll be cool! In SR0 LowER search, I had to define different classes for each of them -- flat, gaussian, skew-guassian, and template-based. One additional thing to add on top of your list of requirements -- allow to change the region of interest, for example in the case of blinding or just the need to optimize.

@cecilia-ferrari
Copy link

Ciao!
Based on the code @GiovanniVolta developed for Nucleon Decay disappearance studies, we built a tool for 1D CES fit. It is currently called he_er but as shown at the end of this example notebook can also perform analysis in the low er ROI. Also in this case, depending on the nature of the background component (peak, theoretical spectrum or G4 generated one) the model is implemented with a specific class.
As discussed in the pull request thread, some features still need improvements.

@yuema137 yuema137 self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inference Statistics code physics This PR mainly deals with physics
Projects
None yet
Development

No branches or pull requests

6 participants