Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF model is hard coded in the plugin and should use xedocs #1518

Closed
sebvetter opened this issue Jan 10, 2025 · 1 comment · Fixed by #1519
Closed

CNF model is hard coded in the plugin and should use xedocs #1518

sebvetter opened this issue Jan 10, 2025 · 1 comment · Fixed by #1519
Assignees
@GiovanniVolta @juehang @sebvetter
Labels
invalid This doesn't seem right

Comments

@sebvetter
Copy link

In the CNF peaklet position plugin the model that is loaded is hard-coded. For different correction versions (i.e. different PMT lists) we need to load different models. This should use xedocs.
@sebvetter sebvetter added the invalid This doesn't seem right label Jan 10, 2025
@juehang juehang mentioned this issue Jan 10, 2025
Merged
4 tasks
@juehang
Copy link
Contributor

juehang commented Jan 10, 2025

PR at #1519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiovanniVolta GiovanniVolta

@juehang juehang

@sebvetter sebvetter

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CNF posrec urlconfig fix XENONnT/straxen
3 participants
@GiovanniVolta @juehang @sebvetter