Why not integrate these classes into xoops?

[GregMage]

I noticed that the goffy and mamba modules use classes which are duplicated in all of their modules. This method is problematic to keep these classes up to date (if there is an error or an addition, all the modules must be modified). Why not integrate this great work into xoops?
Could other developers use these classes for their modules?

Personally, I have never integrated these classes because I find the updating work on all my modules too heavy if there are modifications to these classes.

Exemples:

• https://github.com/XoopsModules25x/obituaries/tree/master/class/Common

• https://github.com/XoopsModules25x/xsitemap/tree/master/class/Common

• https://github.com/XoopsModules25x/marquee/tree/master/class/Common

• https://github.com/XoopsModules25x/wgsimpleacc/tree/master/class/Common

I think all modules here have these classes ...

https://github.com/XoopsModules25x

I think we should integrate this into xoops because all of these mods use it! It's a standard!

Can I help you!

[mambax7]

I agree with you that having a library of common classes would be helpful, and this was already suggested in my email about "MTools" on Sept. 8th (you were included on it):

Originally, when I started to add namespaces to our modules, I also added common classes in /class/Common/

The plan was to group them together, so later on we could move them to one common location for all modules. The new central location would become a kind of "incubator" for common functionality, and the Core team could decide which ones could eventually be moved into XMF

Inspired by what Tad did with his "TadTools", I started to work on "MTools", and this is the first experimental version:

https://github.com/mambax7/mtools

Install it first.

Then you can install "Quotes" module to test it:

https://github.com/mambax7/quotes

Thanks to Namespaces, we can now call all the "Common" classes directly from MTools.

Bugs are expected, since this is still in "experimental" phase, but the module should install and when you install the Testdata, it should (hopefully), at least in Admin, show the Quotes and Authors.

FYI: Blocks have not been installed/tested, so don't test them.

Of course, if you think that there is a better way to do it, please let me know. I just would like to move quickly forward, so we can have most modules done for the upcoming XOOPS 2.5.11 release.

Also, if you have recommendations which common classes and function could we extract into "MTools", please let me know.

Let me know if it did work for you...

Michael

We don't want to potentially destabilize the Core with adding extra classes directly into Core, so the strategy was to have XMF with common functionality for all modules, which works very well.

Based on my recent work with namespaces, and seeing what @tad0616 was doing with his modules and TadTools, I thought that it would be good to consider having MTools with some selected functionality for some modules.

Please take a look at MTools and the Quotes modules, and let us know what you think.

[alain01]

Based on my recent work with namespaces, and seeing what @tad0616 was doing with his modules and TadTools, I thought that it would be good to consider having MTools with some selected functionality for some modules.

Yes, I've tested tad'module with this huge Tadtools.
Sure, we should select some functionality, this framework is too big.
But it is convenient to get BT3, BT4, easy to update BT, Colorbox, fullcalendar, Pannellum for example

[GregMage]

I think we have to start integrating some features but not everything. XMF is a good solution, we should define the first class (s) to integrate! As you know I'm not a big fan of adding lots of features that aren't necessarily useful. We must focus on quality. For this I suggest you start with the "common" classes of your modules.

[alain01]

We must focus on quality.

Sure !

For this I suggest you start with the "common" classes of your modules.

Sounds good ! ;-)

[zyspec]

I believe this issue should be tracked in XMF, not in the core. We will move this issue to the Xmf repository.