Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the description of invalidHotWallet for gateway_balances #2949

Open
cindyyan317 opened this issue Jan 17, 2025 · 3 comments
Open

Update the description of invalidHotWallet for gateway_balances #2949

cindyyan317 opened this issue Jan 17, 2025 · 3 comments
Assignees
@maria-robobug
Labels
clio content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts

Comments

@cindyyan317
Copy link

Related PR:
XRPLF/clio#1830

Code snippet:
https://github.com/XRPLF/rippled/blob/develop/src/xrpld/rpc/handlers/GatewayBalances.cpp#L129

rippled does not check the trustline of hotwallet. In PR1830, Clio also removed such check. hot wallet's balance can be 0 sometimes.

When format of hotwallet field is invalid:
api version 1 returns invalidHotWallet
api version >1 returns invalidParams
@maria-robobug maria-robobug self-assigned this Jan 27, 2025
@maria-robobug maria-robobug moved this to Backlog in XRPL Docs Jan 29, 2025
@maria-robobug maria-robobug added the content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts label Jan 29, 2025
@maria-robobug maria-robobug moved this from Backlog to In Progress in XRPL Docs Jan 29, 2025
@maria-robobug
Copy link
Contributor

@cindyyan317 what version was this change introduced in Clio, or is it an upcoming release change?

@cindyyan317
Copy link
Author

@cindyyan317 what version was this change introduced in Clio, or is it an upcoming release change?

@maria-robobug It is for the upcoming release.

@volkanutkuurl
Copy link

wallet güncellestirme extra olarak wallet güvenliği nasıl saglarım

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maria-robobug maria-robobug

Labels
clio content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts
Projects
XRPL Docs
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maria-robobug @cindyyan317 @volkanutkuurl