From a02c686c63cbbd30c74610522d38cbc8b7cb9eb8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebasti=C3=A1n=20Duque=20Mesa?=
 <675763+sduquemesa@users.noreply.github.com>
Date: Wed, 17 Nov 2021 23:19:29 -0500
Subject: [PATCH] Upload wheels to S3 (#301)

* config [github/workflows] - wheelhouse_uploader: upload to S3

* format [workflows] - build: add new line at end of fiel

* refactor [workflows] - build: upload artifacts to github

* bump [workflows/build] - libcloud version

* [test] remove condition to only upload on master

* fix [workflows/build] - set S3 bucket region name

* refactor [build] - only upload wheels from master branch

* fix [test_hafnian_approx] - test_ones_approx: loosen up test condition

This test sometimes fails due to the random seed. The assert condition is loosen so it won't fail that frequently.
---
 .github/workflows/build.yml            | 29 +++++++++++++++-----------
 thewalrus/tests/test_hafnian_approx.py |  2 +-
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 463285b72..353c46bf0 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -50,16 +50,18 @@ jobs:
         env:
           CIBW_ARCHS_LINUX: ${{matrix.arch}}
 
-      - uses: kittaakos/upload-artifact-as-is@v0
+      - name: Upload wheels to github artifacts
+        uses: kittaakos/upload-artifact-as-is@v0
         if: github.ref == 'refs/heads/master'
         with:
           path: ./wheelhouse/
 
-      - name: Upload Wheels
+      - name: Upload wheels to xanadu-wheels
         if: github.ref == 'refs/heads/master'
         run: |
-          pip install --user https://github.com/joerick/libcloud/archive/v1.5.0-s3fix.zip wheelhouse-uploader
-          python -m wheelhouse_uploader upload --provider-name S3 --local-folder ./wheelhouse/ xanadu-wheels
+          pip install --user https://github.com/apache/libcloud/archive/refs/tags/v3.4.1.zip wheelhouse-uploader
+
+          python -m wheelhouse_uploader upload --provider-name S3 --region us-east-1 --local-folder ./wheelhouse/ xanadu-wheels
 
   mac-wheels-x86-64:
     name: wheels macos
@@ -109,16 +111,17 @@ jobs:
         env:
           CIBW_ARCHS_MACOS: ${{matrix.arch}}
 
-      - uses: kittaakos/upload-artifact-as-is@v0
+      - name: Upload wheels to github artifacts
+        uses: kittaakos/upload-artifact-as-is@v0
         if: github.ref == 'refs/heads/master'
         with:
           path: ./wheelhouse/
 
-      - name: Upload Wheels
+      - name: Upload wheels to xanadu-wheels
         if: github.ref == 'refs/heads/master'
         run: |
-          pip install --user https://github.com/joerick/libcloud/archive/v1.5.0-s3fix.zip wheelhouse-uploader
-          python -m wheelhouse_uploader upload --provider-name S3 --local-folder ./wheelhouse/ xanadu-wheels
+          pip install --user https://github.com/apache/libcloud/archive/refs/tags/v3.4.1.zip wheelhouse-uploader
+          python -m wheelhouse_uploader upload --provider-name S3 --region us-east-1 --local-folder ./wheelhouse/ xanadu-wheels
 
   win-wheels:
     name: wheels windows
@@ -159,14 +162,16 @@ jobs:
       - name: Build wheels
         uses: pypa/cibuildwheel@v1.12.0
 
-      - uses: kittaakos/upload-artifact-as-is@v0
+      - name: Upload wheels to github artifacts
+        uses: kittaakos/upload-artifact-as-is@v0
         if: github.ref == 'refs/heads/master'
         with:
           path: ./wheelhouse/
 
-      - name: Upload Wheels
+      - name: Upload wheels to xanadu-wheels
         if: github.ref == 'refs/heads/master'
         run: |
-          pip install --user https://github.com/joerick/libcloud/archive/v1.5.0-s3fix.zip wheelhouse-uploader
-          python -m wheelhouse_uploader upload --provider-name S3 --local-folder ./wheelhouse/ xanadu-wheels
+          pip install --user https://github.com/apache/libcloud/archive/refs/tags/v3.4.1.zip wheelhouse-uploader
+
+          python -m wheelhouse_uploader upload --provider-name S3 --region us-east-1 --local-folder ./wheelhouse/ xanadu-wheels
 
diff --git a/thewalrus/tests/test_hafnian_approx.py b/thewalrus/tests/test_hafnian_approx.py
index a5927c534..a709afc76 100644
--- a/thewalrus/tests/test_hafnian_approx.py
+++ b/thewalrus/tests/test_hafnian_approx.py
@@ -54,4 +54,4 @@ def test_ones_approx(n):
     A = np.float64(np.ones([2 * n, 2 * n]))
     haf = hafnian(A, approx=True, num_samples=10000)
     expected = fac(2 * n) / (fac(n) * (2 ** n))
-    assert np.abs(haf - expected) / expected < 0.15
+    assert np.abs(haf - expected) / expected < 0.2