Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional arguments in passive_transformation #327

Open
1 task done
thisac opened this issue Feb 8, 2022 · 0 comments
Open
1 task done

Optional arguments in passive_transformation #327

thisac opened this issue Feb 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@thisac
Copy link
Contributor

thisac commented Feb 8, 2022

Before posting a feature request

  • I have searched exisisting GitHub issues to make sure the feature request does not already exist.

Feature details

Both arguments mu and cov are required when calling thewalrus.symplectic.passive_transformation, even when only one of them is required. For example, to calculate the transformation for an covariance matrix only, a dummy-mu still needs to be created and passed.

dummy_mu = np.zeros([len(cov)])
_, cov = passive_transformation(dummy_mu, cov, T))

It would be good to be able to optionally pass the mu argument in the above case.

Implementation

No response

How important would you say this feature is?

1: Not important. Would be nice to have.

Additional information

No response

@thisac thisac added the enhancement New feature or request label Feb 8, 2022
@thisac thisac mentioned this issue Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant