Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS odometry not published if NavSatStatus equals 1 or 2 #20

Open
lio94 opened this issue Jun 20, 2023 · 1 comment
Open

GPS odometry not published if NavSatStatus equals 1 or 2 #20

lio94 opened this issue Jun 20, 2023 · 1 comment

Comments

@lio94
Copy link

lio94 commented Jun 20, 2023

Hi, great work in making LIO-SAM work with 6DOF IMU and without depending on the robot_localization modules!

Just thought to make a small remark. I had trouble getting the GPS odometry topic published, and noticed that in line https://github.com/YJZLuckyBoy/liorf/blob/0ecccff3b1c1d96f72a8b02b3330a08d6425e2ba/src/mapOptmization.cpp#LL279C13-L279C19 there is a condition

        if (gpsMsg->status.status != 0)
            return;

This prevented in my case the GPS odometry from being published, since the custom NavSatFix message from my RTK GNSS setup encodes the states STATUS_SBAS_FIX and STATUS_GBAS_FIX to represent whether RTK fix is achieved or not.

Thus, it might be more generalizable to only neglect the GPS if the status is STATUS_NO_FIX:

        if (gpsMsg->status.status == -1)
            return;
@YJZLuckyBoy
Copy link
Owner

You are right. however, considering that the status values of individual gnss devices are not in standard format, this condition needs to be modified according to your own gnss device status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants