Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emum-ify constants #106

Open
izumin5210 opened this issue Sep 30, 2015 · 0 comments
Open

Emum-ify constants #106

izumin5210 opened this issue Sep 30, 2015 · 0 comments
Labels
enhancement

Comments

@izumin5210
Copy link

#80

WHY

PIN番号やOUTPUT/INPUTなどの定数がint型になっており，不正な入力が入ってくる可能性がある．
その対応のために余計なvalidation等も入っておりややこしい．

HOW

定数をEnum化する．
konashi1/konashi2対応も利用するE<E extends Enum>を差し替えるだけで容易に実現可能（な気がする）．
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@izumin5210 @kiryuxxu