Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es6 import #23

Open
imaksp opened this issue Jul 19, 2016 · 7 comments
Open

Add support for es6 import #23

imaksp opened this issue Jul 19, 2016 · 7 comments

Comments

@imaksp
Copy link

imaksp commented Jul 19, 2016

Please add support for es6 import.
e.g. for ui-router
import uiRouter from 'angular-ui-router'

@Yankovsky
Copy link
Owner

@aks0020 I am a bit short of time, maybe you want to make pr?

@ekarudianto
Copy link

+1

@ekarudianto
Copy link

Hi @Yankovsky I've forked your repo and made my self the directive and the support of using es6 here

https://github.com/ekarudianto/nouislider-angular-es6

I put your name as the original creator, would you mind if I publish it to npm ? since I'd like to use it personaly for my current project ?

@Yankovsky
Copy link
Owner

@ekarudianto @aks0020 just to clarify, what is the point of using es6 imports in this lib? It only depends on noUiSlider and assumes that it is available in window object.

@ekarudianto
Copy link

Yes I was using webpack as the build tool, and it won't work if I just do 'import' from your repo since you're not treat it as a module .. @Yankovsky

@Yankovsky
Copy link
Owner

@ekarudianto @aks0020 do you still need this feature?

@ekarudianto
Copy link

Hi @Yankovsky, not really anymore no :) sorry for the late reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants