Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Codebase with Refactoring #2

Open
Yasir761 opened this issue Oct 19, 2024 · 4 comments
Open

Enhance Codebase with Refactoring #2

Yasir761 opened this issue Oct 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Yasir761
Copy link
Owner

The code could be refactored for better readability and performance. The current implementation has a lot of repetitive logic that can be improved.

Tasks

  • Refactor the code to reduce repetition.
  • Ensure functionality remains the same.
  • Write unit tests for the refactored code.

Guidelines

  • Follow the project's coding style.
@Yasir761 Yasir761 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2024
@tyagidevansh
Copy link
Contributor

/assign

@tyagidevansh
Copy link
Contributor

Can you provide a .env.example file? Also it seems like adding card info is necessary for accessing mapbox access tokens, is there a sample token you can provide that would only be useful for testing (have strict usage limits or timeouts)? I wish to contribute however I can't really run it locally right now.

@Yasir761
Copy link
Owner Author

@tyagidevansh , Thanks for your interest in contributing! I apologize for the confusion—this project actually uses OpenStreetMap tiles, so no Mapbox token is required.

@tyagidevansh
Copy link
Contributor

Ah okay got it. Thanks for including .env.example in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants