Bump wgpu to 22.1 #111
Merged
Bump wgpu to 22.1 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few wgpu structs that this crate uses had fields added, but they're ones where `Default::default` or `None` make sense, so I've inserted them to get the build to work on the new version. This is a breaking change for dependents relying on their own wgpu dependencies, so I've bumped the version number and updated other dependencies that transitively rely on wgpu.
Added the new wgpu structure fields in various places within the examples. Also, since bumping wgpu meant bumping winit, the winit code in the examples had become outdated (the `EventLoop::run` method was deprecated). I updated the winit code to use `EventLoop::run_app`, which factors out the event loop into a trait. I added a `struct App` for handling the event loop and a `struct AppWindow` for handling setting up the window/gpu (needed for lifetime reasons) to all examples. The functionality is the same before and after the changes.
With the bump to wgpu 22.1, the hashbrown, syn, and bitflag crates all trigger `cargo deny` due to multiple versions being found in Cargo.lock. Different top-level dependencies are depending on different major versions of these crates, and the top-level dependencies are all the most recent version, so I don't think there's anything we can do to dedup these.
Yatekii
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippyreports no issuescargo docreports no issuescargo denyissues have been fixed or added todeny.tomlAdded new functionality @githubname.Description
Bumped wgpu to version 22.1. Consists of three commits:
Related Issues