fix: address incorrect unit long names #11
Conversation
|
This is a lot of work and looks Great. I need some more time on my schedule to read it thoroughly, but wanted to leave thanks here to start! Thank you! |
|
The packages folder was not properly cleaned out when I was verifying the build with The csproj file was updated further to work with |
|
I went back into the PR to review the algorithm for generating unit names and improved it since I did not like my original implementation. Setting the default short, long singular, and long plural names also happens when the array for long names and short names is set instead of relying on the Overall, I think this implementation for it is better. The time it took for the unit tests to complete is still the same as before. |
|
I have retroactively created issues that addressed the small fixes mentioned in my first post as that should be documented in Issues. |
The main purpose of this PR is to address the incorrect long name usage for single values. There are very small fixes present in the PR that occurred as a side effect of fixing the former. This small fixes will be listed in this PR.
With this PR, it will correctly display the singular form of the long name for a unit value (1 day, 1 gram, 1 meter, 1 yard, 1 thou, etc.).
Additionally, the follow small fixes are also present:
Tonneproperty for metric ton and markedTonproperty as deprecated.I also added unit tests to verify validity of the changes.
Fixes #10
Fixes #13
Fixes #14
Resolves #15