Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the new ref forwading API #45

Open
magicmark opened this issue Jun 16, 2018 · 2 comments
Open

Consider using the new ref forwading API #45

magicmark opened this issue Jun 16, 2018 · 2 comments
Milestone

Comments

@magicmark
Copy link
Collaborator

Currently, we use tagRef to pass along a ref to the actual underlying DOM element

Pass in any props! If you need to [pass in a ref](https://reactjs.org/docs/refs-and-the-dom.html#adding-a-ref-to-a-dom-element), you'll need to pass it in as a tagRef:

Looks like there's a new API to address just this though: https://reactjs.org/docs/forwarding-refs.html

it can be useful for some kinds of components, especially in reusable component libraries

Sounds like us :P

@mxmul mxmul added this to the v2 milestone Jan 10, 2019
@mxmul
Copy link
Contributor

mxmul commented Jan 10, 2019

Let's implement this, and get rid of the tagRef prop in a v2 release.

@mxmul
Copy link
Contributor

mxmul commented Apr 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants