-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Handle removed assertEqualXMLStructure() assertion #3
Comments
As this library is described as a forward-compatibility polyfill, I would say that adding back support for removed assertions is out of scope. |
@stof Exactly why it hasn't been done yet. I've opened issues for several of these removals to see how much need/interest there is to polyfill them anyway and we'll take it from there based on 👍 / 👎 's. |
Update: the removal has been executed in PHPUnit upstream: sebastianbergmann/phpunit@47a2d92 |
Update: there is discussion about replacing the functionality with different, improved implementations in: sebastianbergmann/phpunit#4091 |
Not seeing any movement on this upstream, nor significant interest here, so I'm closing this issue. If upstream decides to add a replacement, we'll deal with it, but there nothing to do until that time. |
The
Assert::assertEqualXMLStructure()
assertion was deprecated in PHPUnit 9.1.0 and will be removed in PHPUnit 10.0.0 without replacement.Polyfilling this would require copying most of the code which will be removed from PHPUnit, which I'm hesistant to do.
Refs:
The text was updated successfully, but these errors were encountered: