From 63e5f82ae515b84d94250f7a9e828a53ba9936e5 Mon Sep 17 00:00:00 2001
From: Enrico Battocchi <enrico.battocchi@gmail.com>
Date: Thu, 28 Sep 2023 10:19:32 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
---
 .phpcs.xml.dist                            | 1 -
 phpunit-integration.xml.dist               | 2 +-
 tests/integration/bootstrap.php            | 4 ++--
 tests/integration/post-duplicator-test.php | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
index 50b4a120f..9996be2a7 100644
--- a/.phpcs.xml.dist
+++ b/.phpcs.xml.dist
@@ -89,7 +89,6 @@
 			<!-- Don't trigger on the main file as renaming it would deactivate the plugin. -->
 			<property name="excluded_files_strict_check" type="array">
 				<element value="duplicate-post.php"/>
-				<!-- Don't trigger on test bootstrap files. -->
 			</property>
 
 			<!-- Remove the following prefixes from the names of object structures. -->
diff --git a/phpunit-integration.xml.dist b/phpunit-integration.xml.dist
index 440a3050a..8692218e8 100644
--- a/phpunit-integration.xml.dist
+++ b/phpunit-integration.xml.dist
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit
 	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/7.5/phpunit.xsd"
+	xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/8.5/phpunit.xsd"
 	backupGlobals="false"
 	backupStaticAttributes="false"
 	bootstrap="tests/integration/bootstrap.php"
diff --git a/tests/integration/bootstrap.php b/tests/integration/bootstrap.php
index 849438db0..0c7b6cb95 100644
--- a/tests/integration/bootstrap.php
+++ b/tests/integration/bootstrap.php
@@ -36,14 +36,14 @@
 }
 
 
-// Load some helpful functions.
+// Get access to tests_add_filter() function.
 require_once $_wp_tests_dir . 'includes/functions.php';
 
 /**
  * Activates this plugin in WordPress so it can be tested.
  */
 function _manually_load_plugin() {
-	require YOAST_DUPLICATE_POST_TEST_ROOT_DIR . '../../duplicate-post.php';
+	require_once YOAST_DUPLICATE_POST_TEST_ROOT_DIR . '../../duplicate-post.php';
 }
 
 tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
diff --git a/tests/integration/post-duplicator-test.php b/tests/integration/post-duplicator-test.php
index 19e02f581..25efc1c5d 100644
--- a/tests/integration/post-duplicator-test.php
+++ b/tests/integration/post-duplicator-test.php
@@ -44,6 +44,6 @@ public function test_create_duplicate() {
 
 		$id = $this->instance->create_duplicate( $post, [ 'copy_date' => true ] );
 
-		$this->assertTrue( \is_int( $id ) );
+		$this->assertIsInt( $id );
 	}
 }