-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include metadata in the API endpoints #21861
Merged
thijsoo
merged 11 commits into
feature/dash-phase-1
from
533-include-query-completion-time-and-whether-cache-was-used-in-the-api-endpoint-responses
Nov 26, 2024
Merged
Include metadata in the API endpoints #21861
thijsoo
merged 11 commits into
feature/dash-phase-1
from
533-include-query-completion-time-and-whether-cache-was-used-in-the-api-endpoint-responses
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonidasmi
changed the base branch from
trunk
to
531-add-micro-caching-to-the-api-endpoints
November 25, 2024 13:47
Base automatically changed from
531-add-micro-caching-to-the-api-endpoints
to
feature/dash-phase-1
November 25, 2024 14:30
leonidasmi
added
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Nov 26, 2024
thijsoo
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR + ACC 👍
thijsoo
deleted the
533-include-query-completion-time-and-whether-cache-was-used-in-the-api-endpoint-responses
branch
November 26, 2024 13:50
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
/wp-json/yoast/v1/seo_scores?contentType=post
endpoint"queryTime": 0
and"cacheUsed": true
/wp-json/yoast/v1/seo_scores?contentType=post&taxonomy=category&term=<TERM_ID>
endpoint/wp-json/yoast/v1/readability_scores?contentType=post
endpoint/wp-json/yoast/v1/readability_scores?contentType=post&taxonomy=category&term=<TERM_ID>
endpointRelevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/roadmap/issues/533