Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related key phrase suggestions fix styles for RTL #21869

Open
wants to merge 4 commits into
base: feature/plugin-fixes
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/related-keyphrase-suggestions 0.1.0] Fixes a bug where styles on buttons, intent badge and modal links would not adjust to direction when on rtl view.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Activate yoast premium.
  • Change language to one of the rtl languages (Hebrew/Arabic)
  • Edit a post with focus keyphrase
  • Click on "Add relted keyphrases" and log into your semrush account.
  • Check you see the modal with a table
  • Check the followings:
    • Check the links in the footer of the modal has icons in the right direction.
    • Check the buttons and their icons has the right space.
    • Hover over intent badges and check the tooltip are directly above the badge.
    • The semrush upsell button arrow is in the right direction ( when reaching semrush limit requests)
      Screenshot 2024-11-27 at 15 11 20

Screenshot 2024-11-27 at 15 56 09
Screenshot 2024-11-27 at 16 27 42

  • Change site language back to English
  • Smoke test the above to see it was not affected by this PR.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog labels Nov 27, 2024
@vraja-pro vraja-pro added this to the feature/plugin-fixes milestone Nov 27, 2024
@vraja-pro vraja-pro changed the title Related key phrase suggestions fix arroe in rtl Related key phrase suggestions fix styles for RTL Nov 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build ee1e6f20fd80c3660c80b3e727ff5538e850a230

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.673%

Totals Coverage Status
Change from base Build ce4d99036dce54eee4fe16bf64ab4a837f507611: 0.0%
Covered Lines: 29756
Relevant Lines: 54712

💛 - Coveralls

@vraja-pro vraja-pro linked an issue Nov 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Rtl styling for related keyphrase suggestions
2 participants