Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4.03 for 2D #17

Open
nextonphotos opened this issue Jun 1, 2023 · 9 comments
Open

Godot 4.03 for 2D #17

nextonphotos opened this issue Jun 1, 2023 · 9 comments

Comments

@nextonphotos
Copy link

Hi! I use your system in my Godot 3 project and am looking to transition over to Godot 4.

First off, the warning_ignore lines now cause an error in the editor, but I just commented them out to get things running.

There seems to be a problem with the 2D demo in your project for me. There aren't any errors, however, only the initial zone seems to load in. The mini-map is blank and if I move out of the starting area, everything is just empty. I'm using Godot 4.03.

The 3D demo looks like it works without any problem.

Any ideas what the issue may be?

Thanks!

@Yogoda
Copy link
Owner

Yogoda commented Jun 1, 2023

Hello!

I don't plan to port this system to Godot 4, simply because now there is now a native asynchronous loading of the resources, so it renders my whole system a bit useless.

Check ResourceLoader.load_threaded_request in the Godot 4 docs:
https://docs.godotengine.org/en/stable/classes/class_resourceloader.html

Please tell me if you are able to use this instead.
Joël

@nextonphotos
Copy link
Author

nextonphotos commented Jun 1, 2023 via email

@Yogoda
Copy link
Owner

Yogoda commented Jun 1, 2023

Yes, exactly.

I originally did the system because multithreading is very hard to get right but with the new threaded loading the rest should be pretty easy to do by yourself.

Still, if it is too complicated I can try to update to Godot 4.

Please tell me ;)

@nextonphotos
Copy link
Author

nextonphotos commented Jun 1, 2023 via email

@realpixelbard
Copy link

Just hopping on this thread to say thanks for creating this system!

I can also confirm everything except 2D scene works fine on Godot 4.

It will be great if you can update this to Godot 4, pretty please. 🥺🙏 That will be very helpful for noobs like me.

Yes, exactly.

I originally did the system because multithreading is very hard to get right but with the new threaded loading the rest should be pretty easy to do by yourself.

Still, if it is too complicated I can try to update to Godot 4.

Please tell me ;)

@Yogoda
Copy link
Owner

Yogoda commented Jun 15, 2023

Hello :)

Since you asked nicely I am now obliged to comply hehe.

I will try to port it to Godot 4 when I find the time ;)

@nextonphotos
Copy link
Author

nextonphotos commented Jun 15, 2023 via email

@Yogoda
Copy link
Owner

Yogoda commented Jun 15, 2023

Thank you :) I will ask you if I'm stuck.

@Yogoda
Copy link
Owner

Yogoda commented Jun 26, 2023

Hello, I fixed the 2D demo :)

Please use the latest Godot 4.1 and download the new version from Github.

The issue was really simple: in the zone trigger of the player, uncheck the collision mask 16 and check the layer 16 (zone_triggers). (physics changed a little bit in 4.0).

Have a nice day,
Joël

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants