Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support toStringTag #129

Open
xamgore opened this issue Jun 1, 2020 · 1 comment
Open

Support toStringTag #129

xamgore opened this issue Jun 1, 2020 · 1 comment
Labels
enhancement

Comments

@xamgore
Copy link
Contributor

xamgore commented Jun 1, 2020 •
edited
Loading

According to the latest spec and typescript definitions, standard Map interface implements Symbol.toStringTag property.

(new Map())[Symbol.toStringTag]
> "Map"

Maybe DefaultMap and other data structures in mnemonist should do the same?
@Yomguithereal
Copy link
Owner

Sure @xamgore. Why not? Could be a useful addition for some use cases. This could be done in a similar fashion than nodejs custom inspection symbol here to ensure that it does not break usage with older runtimes. You need to check that Symbol do exist and that this particular symbol also exists before setting it to the required prototypes. Do you want to open a PR to add this to structures that are useful to you?

mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 7, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
d704604 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 7, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
418ff25 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
@mrflip mrflip mentioned this issue Aug 7, 2022
Open
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 7, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
d858639 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 7, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
41d5464 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 7, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
839c3cf 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 8, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
985a614 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 8, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
9218206 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
mrflip added a commit to tookstock-deps/mnemonist that referenced this issue Aug 8, 2022
@mrflip
feat: LRUCache/LRUMap family -- inspect and toString improvements
a97d6b0 
* LRUCache and family .inspect limits its output -- showing the youngest items, and ellipsis, and the oldest item. Options allow dumping the raw object or controlling the size of output (and the number of items a console.log will mindlessly iterate over).
* LRUCache and family all have inspect wired up to the magic 'nodejs.util.inspect.custom' symbol property that drives console.log output
* LRUCache and family all have a summaryString method returning eg 'LRUCache[8/200]' for a cache with size 8 and capacity 200, wired to the magic Symbol.toStringTag property that drives string interpolation (partially addresses Yomguithereal#129).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yomguithereal @xamgore