Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug Generalized Suffix Array - longestCommonSubsequence #209

Open
ghost opened this issue Jul 30, 2023 · 1 comment
Open

Possible bug Generalized Suffix Array - longestCommonSubsequence #209

ghost opened this issue Jul 30, 2023 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Jul 30, 2023

To reproduce:

var GeneralizedSuffixArray = require('mnemonist/suffix-array').GeneralizedSuffixArray;

let gsa = new GeneralizedSuffixArray(["abcde", "ace"]);
let actual = gsa.longestCommonSubsequence();
let expected = "ace";
console.assert(actual == expected);

longestCommonSubsequence gives back "a" in this instance.

@Yomguithereal
Copy link
Owner

This is a duplicate of #196. There is indeed a bug here but I need quite a lot of time to fix it and I don't really have any incentive in the short term to do so. I will of course review a PR on the matter though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant