fix: disallow nested ThreadConfigs (#1200)

Yonom · Nov 20, 2024 · c3027a0 · c3027a0
1 parent 10d70db
commit c3027a0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/.changeset/tough-spoons-behave.md b/.changeset/tough-spoons-behave.md
@@ -0,0 +1,5 @@
+---
+"@assistant-ui/react": patch
+---
+
+fix: disallow nested ThreadConfigs
diff --git a/packages/react/src/ui/thread-config.tsx b/packages/react/src/ui/thread-config.tsx
@@ -192,14 +192,23 @@ export const ThreadConfigProvider: FC<ThreadConfigProviderProps> = ({
 }) => {
   const hasAssistant = !!useAssistantRuntime({ optional: true });
 
-  const configProvider =
-    config && Object.keys(config ?? {}).length > 0 ? (
-      <ThreadConfigContext.Provider value={config}>
-        {children}
-      </ThreadConfigContext.Provider>
-    ) : (
-      <>{children}</>
+  const hasConfig = config && Object.keys(config).length > 0;
+  const outerConfig = useThreadConfig();
+
+  if (hasConfig && Object.keys(outerConfig).length > 0) {
+    throw new Error(
+      "You are providing ThreadConfig to several nested components. Please provide all configuration to the same component.",
     );
+  }
+
+  const configProvider = hasConfig ? (
+    <ThreadConfigContext.Provider value={config}>
+      {children}
+    </ThreadConfigContext.Provider>
+  ) : (
+    <>{children}</>
+  );
+
   if (!config?.runtime) return configProvider;
 
   if (hasAssistant) {