Merge pull request #113 from VampireChicken12/dev

Refactor: scroll wheel volume control modifier key
YouTube-Enhancer · Nov 20, 2023 · a312ef9 · a312ef9
2 parents de1097e + 4f9d92e
commit a312ef9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/public/locales/en-US.json b/public/locales/en-US.json
@@ -135,11 +135,7 @@
 						"title": "Press a modifier key to enable volume adjustment with the scroll wheel.",
 						"label": "Enable modifier key"
 					},
-					"options": {
-						"altKey": "{{KEY}} key",
-						"ctrlKey": "{{KEY}} key",
-						"shiftKey": "{{KEY}} key"
-					},
+					"optionLabel": "{{KEY}} key",
 					"select": {
 						"label": "Modifier key",
 						"title": "The modifier key to use"

diff --git a/public/locales/en-US.json.d.ts b/public/locales/en-US.json.d.ts
@@ -130,7 +130,7 @@ interface EnUS {
 						label: "Enable modifier key";
 						title: "Press a modifier key to enable volume adjustment with the scroll wheel.";
 					};
-					options: { altKey: "{{KEY}} key"; ctrlKey: "{{KEY}} key"; shiftKey: "{{KEY}} key" };
+					optionLabel: "{{KEY}} key";
 					select: { label: "Modifier key"; title: "The modifier key to use" };
 					title: "Scroll Wheel Modifier Key";
 				};

diff --git a/src/components/Settings/Settings.tsx b/src/components/Settings/Settings.tsx
@@ -174,19 +174,19 @@ export default function Settings({
 	});
 	const scrollWheelVolumeControlModifierKeyOptions = [
 		{
-			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.options.altKey", {
+			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.optionLabel", {
 				KEY: "Alt"
 			}),
 			value: "altKey"
 		},
 		{
-			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.options.ctrlKey", {
+			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.optionLabel", {
 				KEY: "Ctrl"
 			}),
 			value: "ctrlKey"
 		},
 		{
-			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.options.shiftKey", {
+			label: t("settings.sections.scrollWheelVolumeControl.modifierKey.optionLabel", {
 				KEY: "Shift"
 			}),
 			value: "shiftKey"