Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XDG Desktop Portals on Linux instead of screenshot tools #1010

Open
liferooter opened this issue Mar 20, 2023 · 1 comment · May be fixed by #1053
Open

Use XDG Desktop Portals on Linux instead of screenshot tools #1010

liferooter opened this issue Mar 20, 2023 · 1 comment · May be fixed by #1053
Labels
investigate

Comments

@liferooter
Copy link

The application needs an ability to scan QR code from screen, but arbitrary reading from screen is not supported on Wayland for security reasons. But an ability to get screen content when needed is needed sometimes. So there is an API for that. There is a generic API for permission-based access granting on Linux. It's called XDG Desktop Portals. There is a portal for taking screenshot.

It's already used in some apps for the same thing. For example, Authenticator, an application for generating two-factor codes, uses the portal to scan QR code.

There are some advantages of this way to scan QRs from the screen:

  • Universality. The portal will work on every desktop environment that support it. Your current hack using GNOME Screenshot and Spectacle requires GNOME Screenshot and Spectacle to be installed and also only works on GNOME and KDE, but the portal works on GNOME, KDE, Elementary, wlroots-based WMs and every desktop environment that supports or will support the portal.
  • Sandboxability. The portal works well with sandboxing systems like Flatpak and Snap, so the application will be able to work without unrestricted access to the host system.
  • Consistency. You won't need to use different parts of code for different Linux desktop environments since the portal API is unified.
  • Availability. GNOME Screenshot and Spectacle can be or not bet installed on the machine. But XDG Desktop Portals is very common and standard thing that is usually installed on every Linux computer.
  • Long-term support: Your current hack with GNOME Screenshot and Spectacle supposes that these tools won't change their CLI and behavior. But they can, since they're not designed as any kind of public API. The portal API is a public API that is expected to be stable and supported since applications are expected to use it.
@liferooter liferooter mentioned this issue Mar 20, 2023
Closed
@evan-a-a evan-a-a linked a pull request Apr 19, 2023 that will close this issue
Open
@trinitronx
Copy link

trinitronx commented Aug 23, 2024 •
edited
Loading

Solving this issue would get the QR code screenshot feature working for Wayland systems.

Adding the following error message from Sway + Wayland system for SEO visibility:

11:46:02.007 [helper] ERROR: 
11:46:02.007 [helper] ERROR: (gnome-screenshot:1642482): Handy-WARNING **: 11:46:02.007: Using GtkSettings:gtk-application-prefer-dark-theme together with HdyStyleManager is unsupported. Please use HdyStyleManager:color-scheme instead.
11:46:02.149 [helper] ERROR: 
11:46:02.149 [helper] ERROR: ** (gnome-screenshot:1642482): WARNING **: 11:46:02.149: Unable to use GNOME Shell's builtin screenshot interface: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
11:46:02.149 [helper] ERROR: 
11:46:02.149 [helper] ERROR: ** (gnome-screenshot:1642482): CRITICAL **: 11:46:02.149: Unable to capture a screenshot of any window
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RpcResponse.error(status: invalid-command, message: Invalid parameters: Unable to capture screenshot, body: {})

jonasbb added a commit to jonasbb/com.yubico.yubioath that referenced this issue Jan 11, 2025
@jonasbb
Provide a mock gnome-screenshot command to take screenshots using the…
96d130d 
… xdg-desktop-portal DBus API

The app does not use the xdg-desktop-portal API for screenshots yet. It
can fall back to using the gnome-screenshot command. That is not
provided by the runtime.

Instead this commit adds a mock gnome-screenshot command that uses the
portal API for taking screenshots and saves them to a file. This makes
loading QR codes work from within a flatpak.

flathub#78
Yubico/yubioath-flutter#1010
@jonasbb jonasbb mentioned this issue Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify screenshot capture and add support for wayland evan-a-a/yubioath-flutter
3 participants
@trinitronx @dainnilsson @liferooter