[BUG] : Deleting playlist with "delete maps" option enabledgives an error

[ghost]

Issue encountered

tried to delete a playlist and maps together - got an error

deleting without maps works ok

Expected Behavior

No response

Steps to Reproduce

try to delete a playlist together with maps

Operating System

Windows 11

Version

1.5 alpha-4

Additional Context

2024-10-15-v1.5.0-alpha.4.log

[silentrald]

@kek123321 looking at the logs, there's a broken map file that triggered the error. If you don't mind, can you check if there's any weird info.dat file in any of the downloaded map folders. The logs show that an info.dat is a binary file (I think?) and not a json file.

Also probably best if you can send the bplist/playlist file as well so that we can replicate your issue.

[ghost]

ok so i dont really think looking through every single map is an option

there are the playlists (none of them are deletable)
Playlists.zip
and i cant upload my 59 petabyte zip bomb maps folder since github allows only up to 25MB
i could try to delete all maps to solve this problem but if another broken map makes its way into the game it will probably be broken again, and redownloading gigabytes of maps this often is kinda ass

[silentrald]

i could try to delete all maps to solve this problem but if another broken map makes its way into the game it will probably be broken again, and redownloading gigabytes of maps this often is kinda ass

Hmmm, yeah that seems to be problematic. Let me see if there can be a fix to handle broken/corrupted "info.dat" files with BSM. You can hold of in nuking your songs folder in any case.

[silentrald]

@kek123321 got #613 as a workaround fix to just immediately delete map folders with corrupted info.dat files.

You can validate this either before or after the PR gets merged.

[silentrald]

Can you also check the latest build in any case since it added handling on those map folders. Although looking at it this doesn't delete them outright, you might have to check in the logs so see the offending map folders then delete them manually.

https://github.com/Zagrios/bs-manager/actions/runs/11352293420, click the release-windows-latest build.

[ghost]

after i deleted this map, i tried deleting a playlist with maps, and this time it doesnt give me any errors, however, the maps still remain in my map folder
2024-10-17-v1.5.0-alpha.4.log
sometimes they do get deleted, sometimes they dont

[silentrald]

after i deleted this map, i tried deleting a playlist with maps, and this time it doesnt give me any errors, however, the maps still remain in my map folder
2024-10-17-v1.5.0-alpha.4.log
sometimes they do get deleted, sometimes they dont

@kek123321 looked into this log file, seems that it contains a 429 too much request error from beatsaver which just means that we're throttling the site with to many download requests, might need to add a safety net for this in BSM so that it won't do this.

[2024-10-17 03:27:52.285] [error] Error: HTTP error! status: 429 https://beatsaver.com/api/maps/hash/beb6f5099becbe99583088f1ea924aa0118730ff
    at p.getJSON (C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1202645)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at o.getMapsDetailsByHashs (C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1209487)
    at C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1210946
    at async Promise.allSettled (index 0)
    at a.getMapDetailsFromHashs (C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1210896)
    at C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1130198
    at C:\Users\meeshka\AppData\Local\Programs\bs-manager\resources\app.asar\dist\main\main.js:14:1130129

---

Hmmm can't replicate the issue though, can you check which playlists and maps combination are those? So that I may get some ideas why are those maps not getting deleted.