You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #629 applied, deep linking will always be on by default. Meaning that the OneClick section in the settings page does not work as intended. It will only show the checkbox to always be on and can't be toggled off.
(Assume that the user wants to install something from beatsaver)
When the OneClick checkbox is toggled on.
User clicks on OneClick on beatsaver
User is asked to open BSM in the browser
If user accepts, it should install the map to the user version folder.
When the OneClick checkbox is toggled off
User clicks on OneClick on beatsaver
Nothing should happen
Steps to Reproduce
Go to the settings page
Scroll down to the OneClick section
Click any of the checkbox repeatedly, they will only stay on toggled.
Operating System
Linux
Version
1.5.0-alpha.4
Additional Context
The electronjs deep linking code only works with Windows and Mac, if there is anything I missed in the docs then hopefully someone can thread on this issue.
But for now, might need to do a separate custom handling for this that edits the /usr/share/applications/bs-manager.desktop file within the install to update MimeType field there when running BSM.
The text was updated successfully, but these errors were encountered:
Some additional notes. Checking on the electron repository, there is already the xdg-portal code here but its not working correctly, since I'm getting these logs when I try to open the electron app or toggling the OneClick settings that the xdg-mime cmdlet failed.
xdg-mime: application argument missing
Try 'xdg-mime --help' for more information.
Might investigate/patch this on electron side if this is really an electron problem. Will also probably make a hack/workaround in BSM in any case.
Issue encountered
With #629 applied, deep linking will always be on by default. Meaning that the OneClick section in the settings page does not work as intended. It will only show the checkbox to always be on and can't be toggled off.
Also discussed in discord
Expected Behavior
(Assume that the user wants to install something from beatsaver)
When the OneClick checkbox is toggled on.
When the OneClick checkbox is toggled off
Steps to Reproduce
Operating System
Linux
Version
1.5.0-alpha.4
Additional Context
The electronjs deep linking code only works with Windows and Mac, if there is anything I missed in the docs then hopefully someone can thread on this issue.
But for now, might need to do a separate custom handling for this that edits the
/usr/share/applications/bs-manager.desktop
file within the install to update MimeType field there when running BSM.The text was updated successfully, but these errors were encountered: