Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] : OneClick settings does not work in Linux #651

Open
silentrald opened this issue Nov 9, 2024 · 1 comment
Open

[BUG] : OneClick settings does not work in Linux #651

silentrald opened this issue Nov 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working linux

Comments

@silentrald
Copy link
Contributor

silentrald commented Nov 9, 2024

Issue encountered

With #629 applied, deep linking will always be on by default. Meaning that the OneClick section in the settings page does not work as intended. It will only show the checkbox to always be on and can't be toggled off.

Also discussed in discord

Expected Behavior

(Assume that the user wants to install something from beatsaver)

When the OneClick checkbox is toggled on.

  • User clicks on OneClick on beatsaver
  • User is asked to open BSM in the browser
  • If user accepts, it should install the map to the user version folder.

When the OneClick checkbox is toggled off

  • User clicks on OneClick on beatsaver
  • Nothing should happen

Steps to Reproduce

  1. Go to the settings page
  2. Scroll down to the OneClick section
  3. Click any of the checkbox repeatedly, they will only stay on toggled.

Operating System

Linux

Version

1.5.0-alpha.4

Additional Context

The electronjs deep linking code only works with Windows and Mac, if there is anything I missed in the docs then hopefully someone can thread on this issue.

But for now, might need to do a separate custom handling for this that edits the /usr/share/applications/bs-manager.desktop file within the install to update MimeType field there when running BSM.

@silentrald
Copy link
Contributor Author

Some additional notes. Checking on the electron repository, there is already the xdg-portal code here but its not working correctly, since I'm getting these logs when I try to open the electron app or toggling the OneClick settings that the xdg-mime cmdlet failed.

xdg-mime: application argument missing
Try 'xdg-mime --help' for more information.

Might investigate/patch this on electron side if this is really an electron problem. Will also probably make a hack/workaround in BSM in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linux
Projects
None yet
Development

No branches or pull requests

2 participants