Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date C# client usage example? #231

Open
Numpsy opened this issue Mar 18, 2021 · 1 comment
Open

Out of date C# client usage example? #231

Numpsy opened this issue Mar 18, 2021 · 1 comment

Comments

@Numpsy
Copy link

Numpsy commented Mar 18, 2021

Hi,

I've been having a go at dropping a simple remoting client into an existing C# service (as an experiment in something that currently uses NSwag/REST clients).

When I tried to add the proxy calls as described in https://github.com/Zaid-Ajaj/Fable.Remoting/blob/master/documentation/src/dotnet-csharp.md, e.g.

var proxy = Proxy.CreateFromBuilder<IServer>((typeName, funcName) => {
                return $"http://localhost:8080/api/{typeName}/{funcName}";
            });

It fails to build because CreateFromBuilder also requires an isBinarySerialization parameter

let CreateFromBuilder<'t>(f: Func<string, string, string>, isBinarySerialization) =

I believe that isBinarySerialization relates to the support for MessagePack responses, so maybe the documentation is a little out of date with regards to that feature?

@Zaid-Ajaj
Copy link
Owner

Hi @Numpsy thanks for pointing it out, yeah the docs are a bit outdated in this case. I kinda hoped we could solve it by making isBinarySerialization an optional parameter but it is a module function :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants