-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of the skyblock ranking process #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gylfirst
added
bug
Something isn't working
python
Pull requests that update Python code
labels
Nov 20, 2024
… properly, as well fixing non-proper sorted ranking because of level cap
Re refacto sb
Zalk0
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix #102 when merged to main.
This pull request includes several changes to the
chouette/utils/hypixel_data.py
andchouette/utils/ranking.py
files to improve the handling and formatting of experience and ranking data for Hypixel Skyblock. The most important change is the refactoring of ranking message generation and experience value calculation process.Improvements to experience calculations:
chouette/utils/hypixel_data.py
: Change fromslayer_web
toslayer_wolf
,slayer_enderman
andslayer_blaze
and adding theoverflow
experience value in theexperience_to_level
function documentation.Enhancements to ranking data parsing and formatting:
chouette/utils/ranking.py
: Added theformat_ranking_message
function to format ranking messages with appropriate icons for different ranks.chouette/utils/ranking.py
: Refactored theparse_data
function to include level and overflow calculations for skills and slayers, and updated the structure of the ranking dictionary. [1] [2]chouette/utils/ranking.py
: Modified thegenerate_ranking_message
function to handle different categories (level, networth, skills, skill average, slayers) and format messages accordingly.chouette/utils/ranking.py
: Updated thedisplay_ranking
function to work with the refactored data structure and message generation.Raise an error if the bot failed the CloudFlare verification for SkyCrypt API.