Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the skyblock ranking process #103

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Refactoring of the skyblock ranking process #103

merged 11 commits into from
Nov 25, 2024

Conversation

gylfirst
Copy link
Collaborator

@gylfirst gylfirst commented Nov 20, 2024

This pull request will fix #102 when merged to main.

This pull request includes several changes to the chouette/utils/hypixel_data.py and chouette/utils/ranking.py files to improve the handling and formatting of experience and ranking data for Hypixel Skyblock. The most important change is the refactoring of ranking message generation and experience value calculation process.

Improvements to experience calculations:

  • chouette/utils/hypixel_data.py: Change from slayer_web to slayer_wolf, slayer_enderman and slayer_blaze and adding the overflow experience value in the experience_to_level function documentation.

Enhancements to ranking data parsing and formatting:

  • chouette/utils/ranking.py: Added the format_ranking_message function to format ranking messages with appropriate icons for different ranks.
  • chouette/utils/ranking.py: Refactored the parse_data function to include level and overflow calculations for skills and slayers, and updated the structure of the ranking dictionary. [1] [2]
  • chouette/utils/ranking.py: Modified the generate_ranking_message function to handle different categories (level, networth, skills, skill average, slayers) and format messages accordingly.
  • chouette/utils/ranking.py: Updated the display_ranking function to work with the refactored data structure and message generation.

Raise an error if the bot failed the CloudFlare verification for SkyCrypt API.

@gylfirst gylfirst added bug Something isn't working python Pull requests that update Python code labels Nov 20, 2024
@gylfirst gylfirst self-assigned this Nov 20, 2024
Copy link
Owner

@Zalk0 Zalk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTM

@gylfirst gylfirst merged commit 07e3421 into dev Nov 25, 2024
3 checks passed
@gylfirst gylfirst deleted the refacto_sb branch November 25, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants