Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant workflow steps and sleep commands in GCP tests #7677

Closed
teor2345 opened this issue Oct 4, 2023 · 1 comment
Closed

Remove redundant workflow steps and sleep commands in GCP tests #7677

teor2345 opened this issue Oct 4, 2023 · 1 comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 4, 2023

Motivation

In PR #7665 I made a minimal changes to fix an urgent CI bug, retrying each Docker command to fix these errors:

Specifications

https://docs.docker.com/engine/reference/run/#entrypoint-default-command-to-execute-at-runtime

https://linux.die.net/man/8/mke2fs

Complex Code or Requirements

  1. Workflow Cleanups:
  • we could replace the second lightwalletd mount with a symlink in entrypoint.sh
  • this would let us combine the lightwalletd and non-lightwalletd launch steps to simplify the workflow
  • We could cleanup the duplicate commands in entrypoint.sh, but that's already happening in PR ref(docker): combine test and prod entrypoints into one #7660
  1. Workflow Wait Times:
  • we might want to limit the number of times we retry each command, a step or job timeout would be the simplest way to do this
  • we might want to limit the number of recent journal entries that get shown
  • some errors might need us to delete incorrectly created volumes or containers before trying again
  • some of these delete steps might need to end in || true to ignore any delete failures (if the object wasn't actually created)
  • if the retries don't fix the mke2fs errors, calling mke2fs -F -F might (two -Fs will force overwriting busy devices)

Testing

These cleanups don't need to be tested multiple times, but we should set a timeout that's significantly longer than the last few job runs.

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 4, 2023
@mpguerra mpguerra added this to Zebra Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Oct 4, 2023
@teor2345 teor2345 changed the title Move lightwalletd cache symlink to entrypoint.sh and remove redundant sleeps Remove redundant workflow steps and sleep commands in GCP tests Oct 4, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 6, 2023

This ticket isn't relevant any more

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Oct 6, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
Archived in project
Development

No branches or pull requests

2 participants