add(ci): Check that dependencies have all been published to crates.io on release PRs #8992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
A-devops
github-actions
bot
added
the
C-trivial
|
Do we have an issue for this one? It's ok if not, we don't need to create one |
|
We don't. |
|
I think we should create a tracker issue "make changes to the release process" and this can be part of it with also #8934 and others we might need to add. |
|
@mergify refresh |
✅ Pull request refreshed |
oxarbitrage
requested review from
gustavovalverde and
oxarbitrage
and removed request for
a team
|
This seems to be working, i added the release label to the PR to test it: https://github.com/ZcashFoundation/zebra/actions/runs/11940756889/job/33284430420?pr=8992#step:2:721 It can probably be improved, i added @gustavovalverde as the reviewer. |
gustavovalverde
force-pushed
the
check-no-git-refs-for-releases
branch
from
9df4d8c
to
0a5d703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've mistakenly published a Github release that relies on crates from a git source thrice now, so we want to add a test that runs on release PRs to check that there are no git sources in the
Cargo.lockfile.This is a draft PR because the test still needs to be added to CI and run for PRs that have the
A-releaselabel.Solution
Cargo.tomlfile for"source = "git+".TODO:
A-releaselabelTests
This was tested with the
restore-internal-minerbranch to ensure that it panics when there are dependencies being pulled in from git sources.PR Author's Checklist
PR Reviewer's Checklist