Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cargo autoinherit #9041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Run cargo autoinherit #9041

wants to merge 2 commits into from

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The CI seems to be stuck in #9030. This is just a temporal replacement that test the changes against the full suite.

It was done by running cargo autoinherit locally and pushing the results. It is the same code changes as #9030

Solution

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 18, 2024
@oxarbitrage oxarbitrage mentioned this pull request Nov 18, 2024
Closed
7 tasks
@oxarbitrage
Copy link
Contributor Author

The 2 failing tests are expected and unrelated. We can merge either #9030 or this one and close the other one.

@oxarbitrage oxarbitrage added A-compatibility Area: Compatibility with other nodes or wallets, or standard rules P-Medium ⚡ labels Nov 19, 2024
@oxarbitrage oxarbitrage marked this pull request as ready for review November 19, 2024 12:11
@oxarbitrage oxarbitrage requested review from a team as code owners November 19, 2024 12:11
@oxarbitrage oxarbitrage requested review from arya2 and upbqdn and removed request for a team November 19, 2024 12:11
@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates and removed A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Nov 19, 2024
@oxarbitrage
Copy link
Contributor Author

FYI: We are going to wait for Mainnet activation which should be next Saturday 21 of November. So this should be merged probably next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas approved these changes

@arya2 arya2 Awaiting requested review from arya2 arya2 is a code owner automatically assigned from ZcashFoundation/unsafe-rust-reviewers

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/unsafe-rust-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @zancas