Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between RFTools and Climate Control #2

Open
McJty opened this issue Feb 8, 2016 · 3 comments
Open

Incompatibility between RFTools and Climate Control #2

McJty opened this issue Feb 8, 2016 · 3 comments

Comments

@McJty
Copy link

McJty commented Feb 8, 2016

This was reported on the RFTools issue tracker by @ReikaKalseki :
McJtyMods/RFTools#441

I'm not exactly sure what is going on but it seems like GenLayerRiverMixWrapper is calling the superconstructor for GenLayerRiverMix with the two generator chain parameters set to null. I have no idea why this only causes a problem in rftools dimensions but to me it seems suspicious that you are passing null here since many functions in GenLayerRiverMix depend on these values being set. Like for example GenLayerRiverMix:initWorldgenSeed.

Advice wanted. Thanks

@Zeno410
Copy link
Owner

Zeno410 commented Feb 8, 2016

Short answer: GenLayerRiverMixWrapper is not a GenLayerRiverMix; it's a completely different routine. It has to masquerade as GenLayerRiverMix to be handed to vanilla routines. I could stuff dummy routines in the parent but they wouldn't be connected to what's going on.

What is it you need to do with the vanilla parameters?

@ReikaKalseki
Copy link

The thing is its initWithWorldSeed(long seed) function is being called, which makes direct reference to the null internal fields in the parent object.

@Zeno410
Copy link
Owner

Zeno410 commented Feb 8, 2016

OK, I'll pass some dummy genlayers for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants