Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate Installation Instructions #318

Closed
modl21 opened this issue Aug 3, 2020 · 7 comments
Closed

Certificate Installation Instructions #318

modl21 opened this issue Aug 3, 2020 · 7 comments

Comments

@modl21
Copy link

modl21 commented Aug 3, 2020

Describe the bug
Instructions should mention that the file type should be changed to .crt if it is a .cert. Android won't let you install it otherwise.

Screenshots
image

Smartphone (please complete the following information):

  • Device: Pixel 3A
  • OS: Graphene OS
  • Zeus Version: v0.3.0
@Kixunil
Copy link

Kixunil commented Aug 3, 2020

Actually, this should be completely useless. The URI contains the certificate already, so the app should be able to use it. Zap can do it.

Also please see an issue at Zap where we discuss improvements to the TLS UX.

@kaloudis
Copy link
Contributor

kaloudis commented Aug 5, 2020

Actually, this should be completely useless. The URI contains the certificate already, so the app should be able to use it. Zap can do it.

Also please see an issue at Zap where we discuss improvements to the TLS UX.

For now it's needed. Moving forward we will write some native code to prompt the user to auto-import on Android.

I need to see if that's possible on iOS

@Kixunil
Copy link

Kixunil commented Aug 6, 2020

Why not do it the way Zap does it then? It's much better UX, no prompt needed and it works. It's also possible on iOS (I worked with some custom TLS verification code for iOS in the past.)

@kaloudis
Copy link
Contributor

kaloudis commented Aug 6, 2020

@Kixunil Zap uses GRPC instead of REST. With a GRPC client you can easily specify a self-signed cert to accept from the server, it's not as straightforward with REST and React Native.

@kaloudis
Copy link
Contributor

kaloudis commented Aug 6, 2020

@Kixunil would appreciate some help with making this better on iOS if you are able to, just lmk!

@kaloudis
Copy link
Contributor

Original issue fixed here: #315

Added new issue for auto-processing certs here: #335

@ZeusLN ZeusLN closed this as completed Aug 31, 2020
@Kixunil
Copy link

Kixunil commented Sep 1, 2020

Wanted to look into it better but I'm low on time lately. Apple documented the API quite reasonably, so shouldn't be a huge problem but feel free to ping me and ask about specific things if you hit issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants