Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Received and Sent Keysends and Keysend messages under Activity Page #751

Open
deregs opened this issue Feb 2, 2022 · 3 comments
Open
Labels
Design Issue relating to design

Comments

@deregs
Copy link
Contributor

deregs commented Feb 2, 2022

Add new page to show up under Activity page. Similar to current invoice page, but showing amount received and the associated message, if a message was included.

Also, when clicking on a keysend payment on the Activity page, add a message field if the keysend was sent with a message.

@Bosch-0
Copy link
Contributor

Bosch-0 commented Feb 2, 2022

Great idea! Going to have a dedicated 'Keysend' section in settings that will be for sending keysend payments, messages and keeping track of that history.

@Bosch-0 Bosch-0 added the Design Issue relating to design label Feb 2, 2022
@AndySchroder
Copy link

So, I am already getting keysends to show up in the transaction list. Are you asking for a separate page that only shows keysends? Wondering if just adding #1444 and #1330 (comment) and then making an option to filter keysends (which might be helped by lightningnetwork/lnd#7626 (comment)) would be better?

@myxmaster
Copy link
Contributor

@deregs
I don't understand what is meant with "new page" here.
-> Keysend payments are displayed just like other payments in activity. We just didn't display the keysend message so far (should be fixed with #2634).

@Bosch-0
I also don't understand what a dedicated 'Keysend' section in settings could be useful for.

Please explain what you mean, otherwise I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issue relating to design
Projects
None yet
Development

No branches or pull requests

4 participants