From 64ce1788e643ffc086f62f5574fb18e84e58cd2a Mon Sep 17 00:00:00 2001 From: zhgchgli0718 Date: Tue, 4 Oct 2022 11:37:52 +0800 Subject: [PATCH] [fix] optimize welcome message send timing --- .version | 2 +- lib/AndroidFetcher.rb | 3 ++- lib/AppleFetcher.rb | 3 ++- lib/Models/ReviewFetcher.rb | 11 +++++++++++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.version b/.version index 8c9698a..aaf8be7 100644 --- a/.version +++ b/.version @@ -1 +1 @@ -1.3.4 \ No newline at end of file +1.3.5 \ No newline at end of file diff --git a/lib/AndroidFetcher.rb b/lib/AndroidFetcher.rb index ee8b741..0d3b1e7 100644 --- a/lib/AndroidFetcher.rb +++ b/lib/AndroidFetcher.rb @@ -136,8 +136,9 @@ def execute() # init first time, send welcome message - if latestCheckTimestamp == 0 + if latestCheckTimestamp == 0 && isSentWelcomeMessage() == false sendWelcomMessage() + setSentWelcomeMessage() elsif reviews.length > 0 processReviews(reviews, platform) end diff --git a/lib/AppleFetcher.rb b/lib/AppleFetcher.rb index 9dae6f4..5efff05 100644 --- a/lib/AppleFetcher.rb +++ b/lib/AppleFetcher.rb @@ -38,8 +38,9 @@ def execute() end # init first time, send welcome message - if latestCheckTimestamp == 0 + if latestCheckTimestamp == 0 && isSentWelcomeMessage() == false sendWelcomMessage() + setSentWelcomeMessage() elsif reviews.length > 0 reviews = fullfillAppInfo(reviews) processReviews(reviews, platform) diff --git a/lib/Models/ReviewFetcher.rb b/lib/Models/ReviewFetcher.rb index 86a6d2d..7f3eed6 100644 --- a/lib/Models/ReviewFetcher.rb +++ b/lib/Models/ReviewFetcher.rb @@ -31,6 +31,17 @@ def sendWelcomMessage() end end + def setSentWelcomeMessage() + basePath = "#{config.baseExecutePath}/latestCheckTimestamp/" + Helper.createDirIfNotExist(basePath) + File.open("#{basePath}/#{platform}Welcome", 'w') { |file| file.write("") } + end + + def isSentWelcomeMessage() + filePath = "#{config.baseExecutePath}/latestCheckTimestamp/#{platform}Welcome" + return File.exists?(filePath) + end + def setPlatformLatestCheckTimestamp(timestamp) basePath = "#{config.baseExecutePath}/latestCheckTimestamp/" Helper.createDirIfNotExist(basePath)