Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators should not serve BlockRequests #1878

Open
DrZoltanFazekas opened this issue Nov 22, 2024 · 1 comment
Open

Validators should not serve BlockRequests #1878

DrZoltanFazekas opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
Agate Required for mainnet launch

Comments

@DrZoltanFazekas
Copy link
Contributor

Syncing nodes can't distinguish the current validators from other nodes since their latest block contains an outdated validator set. But they can advertise that they don't have any blocks so that nodes don't send them request for blocks that they want to download.

@DrZoltanFazekas DrZoltanFazekas added the Agate Required for mainnet launch label Nov 22, 2024
@shawn-zil shawn-zil self-assigned this Dec 12, 2024
@shawn-zil
Copy link
Contributor

@DrZoltanFazekas
If I understood this issue, it is that nodes which are busy catching up (syncing), should not be queried for blocks, since their database is incomplete anyway. The requestor distributes the requests across different peers, and does not know which ones are syncing.

Is this right?

Also, am I correct in thinking that nodes which are busy syncing, should probably not participate in other requests (e.g. voting) either since they're still syncing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agate Required for mainnet launch
Projects
None yet
Development

No branches or pull requests

2 participants