Fix for receipt format from GetTxnBodiesForTxBlock(Ex) #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxconway
commented
Nov 25, 2024
maxconway
commented
- closes Z2-Converter : GetTxnBodiesForTxBlock shows incorrect data #1883
maxconway
force-pushed
the
max/bugfix/transaction_body_receipts_format_correction
branch
from
9f73fe0 to
8fcc925
Compare
zilliqa/src/api/zil.rs
Outdated
| @@ -1036,6 +1037,11 @@ fn extract_transaction_bodies(block: &Block, node: &Node) -> Result<Vec<Transact | |||
| let receipt = node | |||
| .get_transaction_receipt(*hash)? | |||
| .ok_or(anyhow!("Transaction receipt missing"))?; | |||
| let receipt_response = TransactionReceiptResponse { | |||
| cumulative_gas: ScillaGas(receipt.cumulative_gas_used.0).to_string(), | |||
There was a problem hiding this comment.
Shouldn't this be receipt.cumulative_gas_used.into(), so the amount gets converted from EvmGas to ScillaGas?
There was a problem hiding this comment.
I copied this from the code for GetTxResponse, so I'm guessing it's wrong there too, I'll fix that at the same time
|
Bencher Report| Branch | max/bugfix/transaction_body_receipts_format_correction |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8,394,000.00 (-7.39%) | 10,680,091.61 (78.59%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 2,256,000,000.00 (+15.36%) | 2,413,138,377.17 (93.49%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.